Update broccoli-typescript-compiler to v4.1.0
#894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
tsc-next
branch
2 times, most recently
from
1b3948c to
15f3633
Compare
Turbo87
changed the title
broccoli-typescript-compiler to v4.1.0 broccoli-typescript-compiler to v4.1.0
|
Needs a rebase and is also blocked on addressing my comment in #895... |
…lower case too otherwise this will be an awkward case-insensitive comparison
without this our `test:types` job fails for some reason
|
Ok, I think we only need one last rebase? |
|
@rwjblue done already 😁 |
|
Added breaking label (since updating TS should be considered a breaking change). |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to update the
broccoli-typescript-compilerdependency to v4.1.0, which internally updates TypeScript from v2.8.3 to v3.2.2. This results in a few different types of errors, most of which got resolved by #889 already. There are two types of errors remaining:foreignobjectinstead offoreignObjectas a tag name string (fixed in this PR)@glimmer/syntax/lib/types/nodes.ts(I've spent 2-3 hours trying to get this to work but still fail to understand how this is supposed to work)I've given up trying to fix the
nodes.tsissue, which is why I opened this PR as WIP.@krisselden according to git you wrote the type declarations in that file. would be great if you could have a look.
This PR will be needed to unblock emberjs/ember.js#17298
UPDATE: After another 2 hours, I seem to have found a solution to the
nodes.tsissues. Afterward, I also discovered other issues which are fixed by #896, #895 and two more commits in this PR./cc @tomdale @rwjblue